xmedcon : proposals for nix systems without gnome #250800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, The wrapGAppsHook seems needed on systems without gnome. Otherwise gui crashes (see also issue 16285) The homepage is set to the main url. A shell hook is added to get those required schemas in a nix-shell. The hicolor-icon-theme is added due to warnings of not finding icon(s) (optional). Greetings, |
flokli
reviewed
Aug 22, 2023
| nativeBuildInputs = [ pkg-config ]; | ||
| nativeBuildInputs = [ pkg-config wrapGAppsHook ]; | ||
|
|
||
| shellHook = '' |
There was a problem hiding this comment.
I don't think we set shellHook anywhere in nixpkgs, and I don't think we patch in random icon themes either. These are usually picked up ambiently from the environment, so I'd skip that part.
NixOSInfra
added
the
12. first-time contribution
| nativeBuildInputs = [ pkg-config ]; | ||
| nativeBuildInputs = [ pkg-config wrapGAppsHook ]; | ||
|
|
||
| shellHook = '' |
|
Closing as abandoned. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)